WARNING: line length of 86 exceeds 80 columns #286: FILE: drivers/net/wireless/intel/iwlwifi/dvm/rx.c:495: + HBUS_TARG_MBX_C_REG_BIT_CMD_BLOCKED); WARNING: line length of 81 exceeds 80 columns #326: FILE: drivers/net/wireless/intel/iwlwifi/fw/dbg.c:595: + RXF2C_DIFF_FROM_PREV); WARNING: line length of 84 exceeds 80 columns #342: FILE: drivers/net/wireless/intel/iwlwifi/fw/dbg.c:2389: + params->in_sample = iwl_trans_read_umac_prph(trans, DBGC_IN_SAMPLE); WARNING: line length of 82 exceeds 80 columns #343: FILE: drivers/net/wireless/intel/iwlwifi/fw/dbg.c:2390: + params->out_ctrl = iwl_trans_read_umac_prph(trans, DBGC_OUT_CTRL); WARNING: line length of 84 exceeds 80 columns #370: FILE: drivers/net/wireless/intel/iwlwifi/fw/dbg.c:2412: + iwl_trans_write_umac_prph(trans, DBGC_IN_SAMPLE, params->in_sample); WARNING: line length of 82 exceeds 80 columns #371: FILE: drivers/net/wireless/intel/iwlwifi/fw/dbg.c:2413: + iwl_trans_write_umac_prph(trans, DBGC_OUT_CTRL, params->out_ctrl); CHECK: Please use a blank line after function/struct/union/enum declarations #459: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.c:30: } +IWL_EXPORT_SYMBOL(iwl_trans_poll_bits_mask); CHECK: Please use a blank line after function/struct/union/enum declarations #470: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.c:39: } +IWL_EXPORT_SYMBOL(iwl_trans_write_direct32); CHECK: Please use a blank line after function/struct/union/enum declarations #482: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.c:54: } +IWL_EXPORT_SYMBOL(iwl_trans_read_prph); WARNING: line length of 88 exceeds 80 columns #485: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.c:56: +void iwl_trans_write_prph_delay(struct iwl_trans *trans, u32 ofs, u32 val, u32 delay_ms) CHECK: Please use a blank line after function/struct/union/enum declarations #494: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.c:64: } +IWL_EXPORT_SYMBOL(iwl_trans_write_prph_delay); CHECK: Please use a blank line after function/struct/union/enum declarations #506: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.c:75: } +IWL_EXPORT_SYMBOL(iwl_trans_set_bits_prph); CHECK: Please use a blank line after function/struct/union/enum declarations #520: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.c:87: } +IWL_EXPORT_SYMBOL(iwl_trans_set_bits_mask_prph); CHECK: Please use a blank line after function/struct/union/enum declarations #532: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.c:99: } +IWL_EXPORT_SYMBOL(iwl_trans_clear_bits_prph); WARNING: line length of 82 exceeds 80 columns #548: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.h:16: +static inline void iwl_trans_clear_bit(struct iwl_trans *trans, u32 reg, u32 mask) WARNING: line length of 82 exceeds 80 columns #559: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.h:23: +static inline int iwl_trans_poll_bits(struct iwl_trans *trans, u32 addr, u32 bits, WARNING: line length of 82 exceeds 80 columns #577: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.h:35: +static inline void iwl_trans_write_prph(struct iwl_trans *trans, u32 ofs, u32 val) WARNING: line length of 84 exceeds 80 columns #605: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.h:55: +static inline u32 iwl_trans_read_umac_prph_no_grab(struct iwl_trans *trans, u32 ofs) WARNING: line length of 82 exceeds 80 columns #615: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.h:63: + return iwl_trans_read_prph(trans, ofs + trans->mac_cfg->umac_prph_offset); WARNING: line length of 82 exceeds 80 columns #624: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.h:69: + iwl_trans_write_prph(trans, ofs + trans->mac_cfg->umac_prph_offset, val); WARNING: line length of 83 exceeds 80 columns #637: FILE: drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c:1413: + data->hw_addr, iwl_trans_read_prph(trans, REG_OTP_MINOR)); CHECK: space preferred before that '|' (ctx:VxE) #709: FILE: drivers/net/wireless/intel/iwlwifi/iwl-scd.h:81: + (0 << SCD_QUEUE_STTS_REG_POS_ACTIVE)| ^ WARNING: line length of 83 exceeds 80 columns #730: FILE: drivers/net/wireless/intel/iwlwifi/iwl-trans.c:460: + UREG_NIC_SET_NMI_DRIVER_NMI_FROM_DRIVER); WARNING: line length of 85 exceeds 80 columns #755: FILE: drivers/net/wireless/intel/iwlwifi/mld/fw.c:214: + IWL_ERR(mld, #reg_name ": 0x%x\n", iwl_trans_read_umac_prph(trans, reg_name)) CHECK: Alignment should match open parenthesis #769: FILE: drivers/net/wireless/intel/iwlwifi/mld/mld.c:41: + *gp2 = iwl_trans_read_prph(mld->trans, mld->trans->mac_cfg->base->gp2_reg_addr); WARNING: line length of 85 exceeds 80 columns #803: FILE: drivers/net/wireless/intel/iwlwifi/mvm/fw.c:266: + IWL_ERR(mvm, #reg_name ": 0x%x\n", iwl_trans_read_umac_prph(trans, reg_name)) WARNING: line length of 90 exceeds 80 columns #812: FILE: drivers/net/wireless/intel/iwlwifi/mvm/fw.c:335: + iwl_trans_read_umac_prph(mvm->trans, WFPM_ARC1_PD_NOTIFICATION)); WARNING: line length of 91 exceeds 80 columns #815: FILE: drivers/net/wireless/intel/iwlwifi/mvm/fw.c:337: + iwl_trans_read_umac_prph(mvm->trans, WFPM_LMAC2_PD_NOTIFICATION)); WARNING: line length of 83 exceeds 80 columns #818: FILE: drivers/net/wireless/intel/iwlwifi/mvm/fw.c:339: + iwl_trans_read_umac_prph(mvm->trans, SB_MODIFY_CFG_FLAG)); WARNING: line length of 81 exceeds 80 columns #821: FILE: drivers/net/wireless/intel/iwlwifi/mvm/fw.c:341: + iwl_trans_read_prph(mvm->trans, CNVI_SCU_SEQ_DATA_DW9)); WARNING: line length of 86 exceeds 80 columns #832: FILE: drivers/net/wireless/intel/iwlwifi/mvm/fw.c:352: + iwl_trans_read_umac_prph(trans, UMAG_SB_CPU_1_STATUS), WARNING: line length of 81 exceeds 80 columns #858: FILE: drivers/net/wireless/intel/iwlwifi/mvm/fw.c:381: + UREG_LMAC1_CURRENT_PC)); WARNING: line length of 89 exceeds 80 columns #864: FILE: drivers/net/wireless/intel/iwlwifi/mvm/fw.c:385: + UREG_LMAC2_CURRENT_PC)); WARNING: line length of 82 exceeds 80 columns #873: FILE: drivers/net/wireless/intel/iwlwifi/mvm/fw.c:619: + sb_cfg = iwl_trans_read_umac_prph(mvm->trans, SB_MODIFY_CFG_FLAG); WARNING: line length of 82 exceeds 80 columns #889: FILE: drivers/net/wireless/intel/iwlwifi/mvm/ops.c:142: + APMG_PS_CTRL_EARLY_PWR_OFF_RESET_DIS, WARNING: line length of 84 exceeds 80 columns #890: FILE: drivers/net/wireless/intel/iwlwifi/mvm/ops.c:143: + ~APMG_PS_CTRL_EARLY_PWR_OFF_RESET_DIS); WARNING: line length of 81 exceeds 80 columns #956: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:158: + iwl_trans_write_direct32(trans, FH_MEM_RCSR_CHNL0_CONFIG_REG, 0); WARNING: line length of 85 exceeds 80 columns #976: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:898: + iwl_trans_set_bit(trans, CSR_INT_COALESCING, IWL_HOST_INT_OPER_MODE); WARNING: line length of 81 exceeds 80 columns #1007: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c:39: + iwl_trans_set_bit(trans, CSR_DBG_HPET_MEM_REG, CSR_DBG_HPET_MEM_REG_VAL); WARNING: line length of 83 exceeds 80 columns #1065: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c:109: + UREG_NIC_SET_NMI_DRIVER_RESET_HANDSHAKE); WARNING: line length of 81 exceeds 80 columns #1070: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c:112: + UREG_DOORBELL_TO_ISR6_RESET_HANDSHAKE); WARNING: line length of 85 exceeds 80 columns #1107: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c:443: + iwl_trans_write_prph(trans, HPM_MAC_LTR_CSR, HPM_MAC_LRT_ENABLE_ALL); WARNING: line length of 83 exceeds 80 columns #1186: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:245: + CSR_GIO_CHICKEN_BITS_REG_BIT_DIS_L0S_EXIT_TIMER); WARNING: line length of 81 exceeds 80 columns #1199: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:255: + iwl_trans_set_bit(trans, CSR_DBG_HPET_MEM_REG, CSR_DBG_HPET_MEM_REG_VAL); WARNING: line length of 81 exceeds 80 columns #1215: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:268: + iwl_trans_set_bit(trans, CSR_ANA_PLL_CFG, CSR50_ANA_PLL_CFG_VAL); WARNING: line length of 82 exceeds 80 columns #1285: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:396: + iwl_trans_clear_bit(trans, CSR_GP_CNTRL, CSR_GP_CNTRL_REG_FLAG_INIT_DONE); WARNING: line length of 90 exceeds 80 columns #1302: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:424: + CSR_GP_CNTRL_REG_FLAG_BUS_MASTER_DISABLE_STATUS, WARNING: line length of 84 exceeds 80 columns #1307: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:428: + iwl_trans_set_bit(trans, CSR_RESET, CSR_RESET_REG_FLAG_STOP_MASTER); WARNING: line length of 83 exceeds 80 columns #1312: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:431: + CSR_RESET_REG_FLAG_MASTER_DISABLED, 100); WARNING: line length of 86 exceeds 80 columns #1335: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:458: + CSR_HW_IF_CONFIG_REG_WAKE_ME_PCIE_OWNER_EN); WARNING: line length of 82 exceeds 80 columns #1349: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:482: + iwl_trans_clear_bit(trans, CSR_GP_CNTRL, CSR_GP_CNTRL_REG_FLAG_INIT_DONE); WARNING: line length of 86 exceeds 80 columns #1381: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:537: + iwl_trans_set_bit(trans, CSR_MBOX_SET_REG, CSR_MBOX_SET_REG_OS_ALIVE); WARNING: line length of 82 exceeds 80 columns #1423: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:700: + LMPM_CHICK_EXTENDED_ADDR_SPACE); WARNING: line length of 81 exceeds 80 columns #1540: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:929: + (fw_mon->physical + fw_mon->size) >> WARNING: line length of 85 exceeds 80 columns #1607: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1154: + iwl_trans_write_umac_prph(trans, UREG_CHICK, UREG_CHICK_MSIX_ENABLE); WARNING: line length of 83 exceeds 80 columns #1669: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1482: + suspend ? UREG_DOORBELL_TO_ISR6_SUSPEND : WARNING: line length of 85 exceeds 80 columns #1783: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:3268: + MON_DMARB_RD_DATA_ADDR); WARNING: line length of 85 exceeds 80 columns #1849: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:3457: + (iwl_trans_umac_prph(trans, FH_MEM_UPPER_BOUND_GEN2) - WARNING: line length of 85 exceeds 80 columns #1850: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:3458: + iwl_trans_umac_prph(trans, FH_MEM_LOWER_BOUND_GEN2)); WARNING: line length of 85 exceeds 80 columns #1894: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:3918: + WFPM_RSRCS_4PHS_REQ_STTS); WARNING: line length of 85 exceeds 80 columns #1912: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:3971: + hw_wfpm_id = iwl_trans_read_umac_prph_no_grab(iwl_trans, WFPM_OTP_CFG1_ADDR); WARNING: line length of 81 exceeds 80 columns #2007: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx.c:521: + iwl_trans_write_direct32(trans, FH_TCSR_CHNL_TX_CONFIG_REG(chan), WARNING: line length of 84 exceeds 80 columns #2008: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx.c:522: + FH_TCSR_TX_CONFIG_REG_VAL_DMA_CHNL_ENABLE | WARNING: line length of 86 exceeds 80 columns #2009: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx.c:523: + FH_TCSR_TX_CONFIG_REG_VAL_DMA_CREDIT_ENABLE); WARNING: line length of 81 exceeds 80 columns #2016: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx.c:528: + reg_val | FH_TX_CHICKEN_BITS_SCD_AUTO_RETRY_EN); WARNING: line length of 82 exceeds 80 columns #2035: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx.c:557: + FH_MEM_CBBC_QUEUE(trans, txq_id), WARNING: line length of 81 exceeds 80 columns #2097: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx.c:987: + iwl_trans_write_direct32(trans, FH_MEM_CBBC_QUEUE(trans, txq_id), WARNING: line length of 86 exceeds 80 columns #2098: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx.c:988: + trans_pcie->txqs.txq[txq_id]->dma_addr >> 8); WARNING: line length of 82 exceeds 80 columns #2102: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx.c:991: + iwl_trans_set_bits_prph(trans, SCD_GP_CTRL, SCD_GP_CTRL_AUTO_ACTIVE_MODE); total: 0 errors, 60 warnings, 9 checks, 1883 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e067e6b34131 ("wifi: iwlwifi: rename io helpers to iwl_trans_ prefix") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 60 warnings, 9 checks, 1883 lines checked