WARNING: line length of 82 exceeds 80 columns #117: FILE: drivers/net/wireless/intel/iwlwifi/dvm/eeprom.c:701: + u32 gp = iwl_trans_read32(trans, CSR_EEPROM_GP) & CSR_EEPROM_GP_VALID_MSK; WARNING: line length of 81 exceeds 80 columns #191: FILE: drivers/net/wireless/intel/iwlwifi/dvm/eeprom.c:992: + CSR_EEPROM_REG_MSK_ADDR & (addr << 1)); WARNING: line length of 81 exceeds 80 columns #310: FILE: drivers/net/wireless/intel/iwlwifi/dvm/main.c:438: + data = iwl_trans_read32(priv->trans, HBUS_TARG_MEM_RDAT); WARNING: line length of 82 exceeds 80 columns #404: FILE: drivers/net/wireless/intel/iwlwifi/dvm/tt.c:150: + CSR_UCODE_DRV_GP1_REG_BIT_CT_KILL_EXIT); WARNING: line length of 82 exceeds 80 columns #410: FILE: drivers/net/wireless/intel/iwlwifi/dvm/tt.c:154: + CSR_UCODE_DRV_GP1_REG_BIT_CT_KILL_EXIT); WARNING: line length of 83 exceeds 80 columns #440: FILE: drivers/net/wireless/intel/iwlwifi/iwl-csr.h:17: + * Use iwl_trans_write32() and iwl_trans_read32() family to access these registers; WARNING: line length of 90 exceeds 80 columns #458: FILE: drivers/net/wireless/intel/iwlwifi/iwl-csr.h:477: + * Use iwl_trans_write32()/iwl_trans_read32() family to access these registers. The MAC HW WARNING: line length of 86 exceeds 80 columns #467: FILE: drivers/net/wireless/intel/iwlwifi/iwl-csr.h:510: + * Do not use iwl_trans_write32()/iwl_trans_read32() family to access these registers; WARNING: line length of 88 exceeds 80 columns #480: FILE: drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:934: + iwl_trans_write32(fwrt->trans, address + offset, value); WARNING: line length of 81 exceeds 80 columns #608: FILE: drivers/net/wireless/intel/iwlwifi/iwl-io.c:89: + (iwl_read_prph_no_grab(trans, ofs) & WARNING: line length of 85 exceeds 80 columns #657: FILE: drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c:1316: + CSR_MAC_ADDR0_STRAP(trans))); WARNING: line length of 85 exceeds 80 columns #659: FILE: drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c:1318: + CSR_MAC_ADDR1_STRAP(trans))); WARNING: line length of 83 exceeds 80 columns #669: FILE: drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c:1328: + mac_addr0 = cpu_to_le32(iwl_trans_read32(trans, CSR_MAC_ADDR0_OTP(trans))); WARNING: line length of 83 exceeds 80 columns #670: FILE: drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c:1329: + mac_addr1 = cpu_to_le32(iwl_trans_read32(trans, CSR_MAC_ADDR1_OTP(trans))); CHECK: Please use a blank line after function/struct/union/enum declarations #682: FILE: drivers/net/wireless/intel/iwlwifi/iwl-trans.c:435: } +IWL_EXPORT_SYMBOL(iwl_trans_write32); CHECK: Please use a blank line after function/struct/union/enum declarations #688: FILE: drivers/net/wireless/intel/iwlwifi/iwl-trans.c:441: } +IWL_EXPORT_SYMBOL(iwl_trans_read32); WARNING: line length of 85 exceeds 80 columns #762: FILE: drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1255: + u32 scratch = iwl_trans_pcie_read32(trans, CSR_FUNC_SCRATCH); WARNING: line length of 83 exceeds 80 columns #824: FILE: drivers/net/wireless/intel/iwlwifi/pcie/internal.h:968: + iwl_trans_pcie_write32(trans, CSR_INT_MASK, trans_pcie->inta_mask); WARNING: line length of 83 exceeds 80 columns #866: FILE: drivers/net/wireless/intel/iwlwifi/pcie/internal.h:1014: + iwl_trans_pcie_write32(trans, CSR_INT_MASK, trans_pcie->inta_mask); WARNING: line length of 83 exceeds 80 columns #880: FILE: drivers/net/wireless/intel/iwlwifi/pcie/internal.h:1044: + iwl_trans_pcie_write32(trans, CSR_INT_MASK, trans_pcie->inta_mask); WARNING: line length of 83 exceeds 80 columns #889: FILE: drivers/net/wireless/intel/iwlwifi/pcie/internal.h:1091: + iwl_trans_pcie_write32(trans, CSR_INT_MASK, trans_pcie->inta_mask); WARNING: line length of 86 exceeds 80 columns #937: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:196: + iwl_trans_pcie_write32(trans, FH_RSCSR_CHNL0_WPTR, rxq->write_actual); WARNING: line length of 82 exceeds 80 columns #941: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:198: + iwl_trans_pcie_write32(trans, HBUS_TARG_WRPTR, rxq->write_actual | WARNING: line length of 86 exceeds 80 columns #999: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:888: + (RX_RB_TIMEOUT << FH_RCSR_RX_CONFIG_REG_IRQ_RBTH_POS) | WARNING: line length of 82 exceeds 80 columns #1063: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:978: + RFH_GEN_CFG_RB_CHUNK_SIZE_64 : WARNING: line length of 84 exceeds 80 columns #1064: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:979: + RFH_GEN_CFG_RB_CHUNK_SIZE_128)); WARNING: line length of 81 exceeds 80 columns #1137: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:2080: + CSR_INT, CSR_INT_BIT_RX_PERIODIC); WARNING: line length of 85 exceeds 80 columns #1146: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:2120: + iwl_trans_pcie_write32(trans, CSR_FH_INT_STATUS, CSR_FH_INT_TX_MASK); WARNING: line length of 88 exceeds 80 columns #1185: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:2299: + iwl_trans_pcie_write32(trans, CSR_MSIX_FH_INT_CAUSES_AD, inta_fh & inta_fh_msk); WARNING: line length of 85 exceeds 80 columns #1195: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:2315: + iwl_trans_pcie_read32(trans, CSR_MSIX_FH_INT_MASK_AD)); WARNING: line length of 85 exceeds 80 columns #1204: FILE: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:2417: + iwl_trans_pcie_read32(trans, CSR_MSIX_HW_INT_MASK_AD)); WARNING: line length of 90 exceeds 80 columns #1228: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c:126: + inta_hw = iwl_trans_pcie_read32(trans, CSR_MSIX_HW_INT_CAUSES_AD); WARNING: line length of 86 exceeds 80 columns #1295: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c:553: + iwl_trans_pcie_write32(trans, CSR_UCODE_DRV_GP1_CLR, CSR_UCODE_SW_BIT_RFKILL); WARNING: line length of 93 exceeds 80 columns #1312: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c:595: + iwl_trans_pcie_write32(trans, CSR_FUNC_SCRATCH, CSR_FUNC_SCRATCH_INIT_VALUE); WARNING: line length of 81 exceeds 80 columns #1329: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:50: + i, iwl_trans_pcie_read32(trans, CSR_MONITOR_STATUS_REG)); WARNING: line length of 90 exceeds 80 columns #1443: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1177: + trans_pcie->fh_init_mask = ~iwl_trans_pcie_read32(trans, CSR_MSIX_FH_INT_MASK_AD); WARNING: line length of 90 exceeds 80 columns #1446: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1179: + trans_pcie->hw_init_mask = ~iwl_trans_pcie_read32(trans, CSR_MSIX_HW_INT_MASK_AD); WARNING: line length of 86 exceeds 80 columns #1466: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1329: + iwl_trans_pcie_write32(trans, CSR_UCODE_DRV_GP1_CLR, CSR_UCODE_SW_BIT_RFKILL); WARNING: line length of 86 exceeds 80 columns #1482: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1352: + iwl_trans_pcie_write32(trans, CSR_UCODE_DRV_GP1_CLR, CSR_UCODE_SW_BIT_RFKILL); WARNING: line length of 86 exceeds 80 columns #1483: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1353: + iwl_trans_pcie_write32(trans, CSR_UCODE_DRV_GP1_CLR, CSR_UCODE_SW_BIT_RFKILL); WARNING: line length of 87 exceeds 80 columns #1568: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2486: + HBUS_TARG_MEM_RDAT); WARNING: line length of 86 exceeds 80 columns #1583: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2537: + vals[offs] = iwl_trans_pcie_read32(trans, HBUS_TARG_MEM_RDAT); WARNING: line length of 87 exceeds 80 columns #1616: FILE: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:3606: + iwl_trans_pcie_write32(trans, inta_addr, inta_hw & sw_err_bit); WARNING: line length of 89 exceeds 80 columns #1673: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c:714: + iwl_trans_pcie_write32(trans, HBUS_TARG_WRPTR, txq->write_ptr | (txq->id << 16)); WARNING: line length of 83 exceeds 80 columns #1706: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx.c:589: + iwl_trans_pcie_write32(trans, FH_TCSR_CHNL_TX_CONFIG_REG(ch), 0x0); WARNING: line length of 81 exceeds 80 columns #1715: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx.c:598: + ch, iwl_trans_pcie_read32(trans, FH_TSSR_TX_STATUS_REG)); WARNING: line length of 82 exceeds 80 columns #1726: FILE: drivers/net/wireless/intel/iwlwifi/pcie/tx.c:1339: + txq->write_ptr | (i << 8)); WARNING: line length of 82 exceeds 80 columns #1791: FILE: drivers/net/wireless/intel/iwlwifi/pcie/utils.h:35: + iwl_pcie_write_prph_no_grab(trans, ofs + trans->mac_cfg->umac_prph_offset, total: 0 errors, 46 warnings, 2 checks, 1513 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 1b1233c574da ("wifi: iwlwifi: avoid unnecessary indirection") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 46 warnings, 2 checks, 1513 lines checked