CHECK: spaces preferred around that '-' (ctx:VxV) #30: FILE: drivers/net/wireless/ath/regd.c:46: +#define ATH_5GHZ_5150_5350 REG_RULE(5150-10, 5240+10, 80, 0, 30, 0),\ ^ CHECK: spaces preferred around that '+' (ctx:VxV) #30: FILE: drivers/net/wireless/ath/regd.c:46: +#define ATH_5GHZ_5150_5350 REG_RULE(5150-10, 5240+10, 80, 0, 30, 0),\ ^ ERROR: Macros with complex values should be enclosed in parentheses #30: FILE: drivers/net/wireless/ath/regd.c:46: +#define ATH_5GHZ_5150_5350 REG_RULE(5150-10, 5240+10, 80, 0, 30, 0),\ + REG_RULE(5260-10, 5350+10, 80, 0, 30,\ NL80211_RRF_NO_IR) BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. CHECK: spaces preferred around that '-' (ctx:VxV) #31: FILE: drivers/net/wireless/ath/regd.c:47: + REG_RULE(5260-10, 5350+10, 80, 0, 30,\ ^ CHECK: spaces preferred around that '+' (ctx:VxV) #31: FILE: drivers/net/wireless/ath/regd.c:47: + REG_RULE(5260-10, 5350+10, 80, 0, 30,\ ^ total: 1 errors, 0 warnings, 4 checks, 49 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit bdb85f403ccd ("wifi: ath: split 5150-5350 regulatory rule") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.